API-10892 techdebt passport selection fix #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwise-va
previously approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Code changes look good and will support adding new IDP's to saml-proxy in the future. It was a good idea to add the decoding of the SAML response and returning the issuer to the utils.
Unit test and regression test all passed. Also tested a login using the sample app with id.me
johnmweisz
reviewed
Sep 11, 2023
…e' into API-10892-techdebt-passport-selection-fix
mwise-va
reviewed
Sep 12, 2023
johnmweisz
reviewed
Sep 18, 2023
…into API-10892-techdebt-passport-selection-fix
|
SAML Proxy will be deprecated and replaced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to API-10892